Remove Postgres auth backend #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noah-Kennedy
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not using it.
Anybody who has so many users that they need a full-blown database, either already has their own DB, or is going to need a lot more user management and administrative features that we're never going to implement. Auth via SSO makes much more sense for big deployments.
The
AuthProviderinterface doesn't separate auth storage from application logic controlling user access. Whenever we want to change account management/permissions logic, it needs to be implemented in each backend separately, so additional auth backends either bitrot or create extra work.Note: the postgres-based crate index remains supported. The storage interface doesn't vary as much, and pg can have a better search.